Skip to content

Specify generic device is less secure #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Dec 15, 2021

Motivation

Find a way to let the user know that generic devices are less secure than standard ones (with crypto)

Change description

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested a review from eclipse1985 December 15, 2021 10:36
@eclipse1985
Copy link
Contributor

A couple of comments:

  • I would change the help message even for the create subcommand since as a user I don't understand which is the difference between create and create-generic

Something like:

fabrizio@ ~ $ arduino-cloud-cli device
Device commands.

Usage:
  arduino-cloud-cli device [command]

Available Commands:
  create               Create a device provisioning the onboard secure element with a valid certificate
  create-generic       Create username and password credentials for a generic device without secure element - WARNING: less secure
  ...
  • Fix the subcommand specific help as well
fabrizio@ ~ $ arduino-cloud-cli device create-generic --help
Create username and password credentials for a generic device without secure element - WARNING: less secure

Usage:
  arduino-cloud-cli device create-generic [flags]

Flags:
  -b, --fqbn string   Device fqbn (default "generic:generic:generic")
  -h, --help          help for create-generic
  -n, --name string   Device name

Global Flags:
      --format string   The output format, can be {text|json}. (default "text")
  -v, --verbose         Print the logs on the standard output.

@polldo
Copy link
Contributor Author

polldo commented Dec 20, 2021

@eclipse1985 thanks
is it more clear now?

I've put
Create a generic device with password authentication - without secure element - WARNING: less secure
instead of
Create username and password credentials for a generic device without secure element - WARNING: less secure
because it seems more consistent with the command, what do you think?

@polldo polldo merged commit 003994d into main Dec 21, 2021
@polldo polldo deleted the polldo/generic-denigration branch December 21, 2021 08:52
polldo pushed a commit that referenced this pull request Sep 2, 2022
device create is for provisioning of crypto-chip devices -> most secure
create-generic is for devices that use authentication with id and password -> less secure
polldo pushed a commit that referenced this pull request Sep 2, 2022
device create is for provisioning of crypto-chip devices -> most secure
create-generic is for devices that use authentication with id and password -> less secure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants