Make arduino15 dir if not exist #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
During 'config init' if the default arduino directory (arduino15) doesn't exist then we're going to create it rather than returning an error
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
During 'config init' if the default arduino directory (arduino15) doesn't exist then we're going to create it rather than returning an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During
config initif the default arduino directory (arduino15) doesn't exist then we want to create it rather than returning an error.Change description
the check
if configPath.NotExist() {is not mandatory becauseconfigPath.MkdirAll()doesn't do anything if the directory exists already. However I put it to avoid cases where the call toMkdirAllfails even if the directory already exists.Additional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.