Skip to content

Improve config #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Improve config #75

merged 4 commits into from
Dec 6, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Dec 2, 2021

Motivation

some changes remained pending from the last refactor

  • readme has not been updated

Change description

  • update readme

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested a review from glumia December 2, 2021 18:08
Copy link
Contributor

@glumia glumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! (added just some minor suggestions for readability)

polldo and others added 4 commits December 6, 2021 17:29
Co-authored-by: Giuseppe Lumia <[email protected]>
Co-authored-by: Giuseppe Lumia <[email protected]>
Co-authored-by: Giuseppe Lumia <[email protected]>
@polldo polldo force-pushed the polldo/improve-config branch from de4397e to 3907c35 Compare December 6, 2021 16:30
@polldo polldo merged commit fff60a0 into main Dec 6, 2021
@polldo polldo deleted the polldo/improve-config branch December 6, 2021 16:30
polldo pushed a commit that referenced this pull request Sep 2, 2022
polldo pushed a commit that referenced this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants