Refactor config init command #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polldo
commented
Nov 25, 2021
| initCommand.Flags().StringVar(&initFlags.destDir, "dest-dir", ".", "Sets where to save the configuration file.") | ||
| initCommand.Flags().BoolVar(&initFlags.overwrite, "overwrite", false, "Overwrite existing config file.") | ||
| initCommand.Flags().StringVar(&initFlags.destDir, "dest-dir", "", "Sets where to save the configuration file") | ||
| initCommand.Flags().BoolVar(&initFlags.overwrite, "overwrite", false, "Overwrite existing config file") |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Giuseppe Lumia <[email protected]>
Co-authored-by: Giuseppe Lumia <[email protected]>
Co-authored-by: Giuseppe Lumia <[email protected]>
eclipse1985
approved these changes
Nov 26, 2021
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
- use arduino15 directory by default for 'config init' - 'config init' command prompts the user to insert client-id and client-secret
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
- use arduino15 directory by default for 'config init' - 'config init' command prompts the user to insert client-id and client-secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the configuration file should be created in
arduino15directory by defaultthe
config initcommand should prompt the user to insert client-id and client-secretChange description
Additional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.