Allow to configure iot-api's url #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glumia
changed the title
glumia
force-pushed
the
glumia/bind-to-dev-environment
branch
from
ebe66de to
5504100
Compare
polldo
force-pushed
the
glumia/bind-to-dev-environment
branch
from
5504100 to
81748a7
Compare
polldo
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Rebased and adapted
An alternative approach is to add the base url as an optional parameter of the configuration, like we did in https://github.com/arduino/arduino-cloud-cli/pull/105/files . This would allow consumers of the command package to change the url programmatically. It would also allow to have a config file for dev environment.
Let's merge this, we can switch to the alternative in the future if needed.
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
* Update config file name * Allow to configure iot-api's url
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
* Update config file name * Allow to configure iot-api's url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At the moment the only way we have to bind the CLI to our development environment is by modifying the source code and recompiling the binary.
This is painful as during development one needs to quickly switch between local/dev/prod environments depending on what he needs to test.
Change description
IOT_API_URLenvironment variable (fallback to production'sapi2.arduino.ccif not set).Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.