Show tags in list commands #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glumia
reviewed
Nov 10, 2021
polldo
force-pushed
the
polldo/show-tags
branch
from
c5889bd to
4ff8dd2
Compare
Co-authored-by: Giuseppe Lumia <[email protected]>
polldo
force-pushed
the
polldo/show-tags
branch
from
bcce783 to
444d874
Compare
polldo
force-pushed
the
polldo/show-tags
branch
from
444d874 to
cb495d3
Compare
eclipse1985
approved these changes
Nov 16, 2021
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
Add tags information in 'thing list' and 'device list' commands
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
Add tags information in 'thing list' and 'device list' commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to give users a way to see the tags on things/devices. Adding tags information in the list command should be good enough.
Change description
Add tags information in
thing listanddevice listcommandsAdditional Notes
The tags
Infofunction returns an error if a tag value is not a string. Alternatively the invalid tags can be simply skipped (at the moment the backend doesn't allow values different from string)Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.