Add create/delete commands for device/thing tags [IOT-1481] #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polldo
changed the title
glumia
approved these changes
Nov 5, 2021
|
|
||
| // CreateTags allows to create or overwrite tags | ||
| // on a resource of Arduino IoT Cloud | ||
| func CreateTags(params *CreateTagsParams) error { |
There was a problem hiding this comment.
We could add a validation of params.Resource here so that if it doesn't have a valid value we avoid loading the configuration and instantiating the iot client for nothing.
What do you think?
glumia
reviewed
Nov 5, 2021
glumia
reviewed
Nov 5, 2021
eclipse1985
approved these changes
Nov 5, 2021
Co-authored-by: Giuseppe Lumia <[email protected]>
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
Introduce tags for things and devices. Implements the following commands: - device create-tags - device delete-tags - thing create-tags - thing delete-tags
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
Introduce tags for things and devices. Implements the following commands: - device create-tags - device delete-tags - thing create-tags - thing delete-tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As per #48 we want to introduce tags for things and devices. This pr implements the create and delete commands for both thing and device tags
Change description
Add commands:
Additional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.