Add dashboard create command #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glumia
reviewed
Oct 14, 2021
glumia
suggested changes
Oct 14, 2021
There was a problem hiding this comment.
We should move internal/template/mocks/Client.go to internal/iot/mocks/Client.go since its a mock for the interface defined in internal/iot/client.go. In this way we can reuse it in other tests if needed, and easily find the implementation by reading the mock and viceversa.
polldo
force-pushed
the
polldo/dashboard-create
branch
from
d007bdd to
8ae3914
Compare
glumia
approved these changes
Oct 15, 2021
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
This command allows users to create new dashboards starting from templates. Changes: - Dashboard create command has been implemented, it takes a template and a map indicating thing_id to be overridden. - A function to convert the template file into a proper dashboard structure has been implemented. Here, the ids of the variables described in the template are fetched; the widget options are filtered; a uuid is assigned to each widget.
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
This command allows users to create new dashboards starting from templates. Changes: - Dashboard create command has been implemented, it takes a template and a map indicating thing_id to be overridden. - A function to convert the template file into a proper dashboard structure has been implemented. Here, the ids of the variables described in the template are fetched; the widget options are filtered; a uuid is assigned to each widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
arduino-cloud-cli should allow users to create new dashboards starting from templates.
Change description
thing_idto be overridden.Additional Notes
information about this command (from the readme):
overrideflag can be used to override the templatething_idplaceholder with the actual ID of the thing to be used.Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.