-
-
Notifications
You must be signed in to change notification settings - Fork 4
CI: Add release workflow #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some minor improvements, a totally optional change (... 😆 ) and added some questions. Overall it's ok for me!
Some feedbacks regarding the pull request description:
-
"A new release is generated on every push..." is a short description of the feature we are introducing, not the motivation of why we need it (e.g. "stakeholders would like to be able to download a binary for their platform as soon as a new version is tagged").
-
Change description is only a summary of the release workflow.
This is valuable information, but what I would expect to see in this section is a brief description of all the changes introduced by the pull request.
In this case, something like:
- Add release Github workflow
- Add tests Github workflow
- Add task files to test and build the tool
- Add gon configuration to sign MacOS binaries as
ARDUINO SA (7KT7ZWMCJT)
.
-
Additional Notes is actually fine :)
We could improve it by adding a reference to its Jira issue IOT-1333 and the cloud cli rfc
@glumia thanks for feedbacks, I tried to integrate them but... If you believe that workflows should be treated better, can you please make a PR to clean/improve them? Thanks |
30eafee
to
7c5aa98
Compare
Add a github workflow that uses a Taskfile to cross-compile the project for the main operating systems. The gon configuration, used to notarize the binary for mac-os, has been fixed. A new release will be generated on every push of a tag named with a version format. * CI: Add release workflow * Disable upload to aws * Enable macos notarization * Edit release archive (- license, + binaries) * Fix release version * Add todos
Add a github workflow that uses a Taskfile to cross-compile the project for the main operating systems. The gon configuration, used to notarize the binary for mac-os, has been fixed. A new release will be generated on every push of a tag named with a version format. * CI: Add release workflow * Disable upload to aws * Enable macos notarization * Edit release archive (- license, + binaries) * Fix release version * Add todos
Motivation
A new release should be generated on every push of a tag named with a version format. This makes the project distribution easier.
Change description
Add a github workflow that uses a Taskfile to cross-compile the project for the main operating systems.
The gon configuration, used to notarize the binary for mac-os, has been fixed.
the steps of the release workflow are:
Additional Notes
At the moment, builds are not uploaded to Arduino's downloads server.
TODO list for the future:
binaries
folder, as soon as a new mechanism for downloading provisioning binaries is introducedReviewer checklist
main
.CONTRIBUTING.md
) and are well formatted.