Skip to content

Wait a while before using serial port #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Wait a while before using serial port #34

merged 4 commits into from
Nov 15, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Sep 16, 2021

Motivation

for some unknown reason we have to add a few second delay between the opening of the serial port and the start of serial communication.

Change description

Add 2 seconds sleep before sending the first serial message to the device

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo force-pushed the polldo/serial-wait branch from 01a118e to e0c578a Compare November 5, 2021 11:22
@polldo polldo marked this pull request as ready for review November 15, 2021 16:24
@polldo polldo merged commit 6b9bdfd into main Nov 15, 2021
@polldo polldo deleted the polldo/serial-wait branch November 15, 2021 16:54
polldo pushed a commit that referenced this pull request Sep 2, 2022
Add 2 seconds sleep before sending the first serial message to the device
polldo pushed a commit that referenced this pull request Sep 2, 2022
Add 2 seconds sleep before sending the first serial message to the device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant