Skip to content

Refactor template format #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 3, 2021
Merged

Refactor template format #30

merged 5 commits into from
Sep 3, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Sep 3, 2021

Motivation

Thing templates are now supported in both json and yaml formats.
This means that, during the thing creation, the thing template can be passed either as json or yaml file.
On the other hand, during the template extraction, the user can specify his preferred format with an appropriate flag. The default value for the format is yaml.

$ ./iot-cloud-cli thing extract --format json

Change description

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo merged commit ded44cb into main Sep 3, 2021
@polldo polldo deleted the polldo/template-format branch September 3, 2021 13:17
polldo added a commit that referenced this pull request Sep 2, 2022
Thing templates are now supported in both json and yaml formats.
This means that, during the thing creation, the thing template can be passed either as json or yaml file.
On the other hand, during the template extraction, the user can specify his preferred format with an appropriate flag. The default value for the format is yaml.
$ ./iot-cloud-cli thing extract --format json

* Thing template - Support both yaml and json formats

* Update docs

* Extract template supports multiple formats

* thing extract - set yaml as default format

* Update readme
polldo added a commit that referenced this pull request Sep 2, 2022
Thing templates are now supported in both json and yaml formats.
This means that, during the thing creation, the thing template can be passed either as json or yaml file.
On the other hand, during the template extraction, the user can specify his preferred format with an appropriate flag. The default value for the format is yaml.
$ ./iot-cloud-cli thing extract --format json

* Thing template - Support both yaml and json formats

* Update docs

* Extract template supports multiple formats

* thing extract - set yaml as default format

* Update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant