Set cmd's optional params as pointers #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
All implemented commands now accept optional parameters as pointers. This change makes the command package more clear and easier to use: if the type of a parameter is a pointer, then it becomes clear that such parameter is optional. So, for example, instead of an empty string now it's possible to pass nil for optional parameters.
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
All implemented commands now accept optional parameters as pointers. This change makes the command package more clear and easier to use: if the type of a parameter is a pointer, then it becomes clear that such parameter is optional. So, for example, instead of an empty string now it's possible to pass nil for optional parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
All implemented commands now accept optional parameters as pointers.
This change makes the command package more clear and easier to use: if the type of a parameter is a pointer, then it becomes clear that such parameter is optional. So, for example, instead of an empty string now it's possible to pass
nilfor optional parameters.Change description
Additional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.