Refactor things [IOT-1310] #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove properties_count, max_value, min_value, persist and tag fields add template name field change helper to remark that a template is being extracted instead of a thing.
thing create command has been split in two commands: - thing create -> create a thing from a template. name parameter is optional and, if it's present, it overrides the name provided by the template - thing clone -> create a thing from an existing thing. name parameter of the new thing is mandatory thing templates have been aligned with general iot cloud templates concept now templates like this: https://github.com/bcmi-labs/cloud-templates/blob/main/templates/home-security-alarm/resources/thing.yml can be directly used to create new things.
eclipse1985
approved these changes
Aug 30, 2021
polldo
added a commit
that referenced
this pull request
Aug 30, 2021
adapt cloud-cli thing templates to the already established concept of template: - extracted templates are more "compliant" with the already known templates - standard cloud thing templates can now be used to create new things * Adapt template extraction remove properties_count, max_value, min_value, persist and tag fields add template name field change helper to remark that a template is being extracted instead of a thing. * Adapt thing creation to rfc thing create command has been split in two commands: - thing create -> create a thing from a template. name parameter is optional and, if it's present, it overrides the name provided by the template - thing clone -> create a thing from an existing thing. name parameter of the new thing is mandatory thing templates have been aligned with general iot cloud templates concept now templates like this: https://github.com/bcmi-labs/cloud-templates/blob/main/templates/home-security-alarm/resources/thing.yml can be directly used to create new things. * Replace Properties with Variables * Update readme
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
adapt cloud-cli thing templates to the already established concept of template: - extracted templates are more "compliant" with the already known templates - standard cloud thing templates can now be used to create new things * Adapt template extraction remove properties_count, max_value, min_value, persist and tag fields add template name field change helper to remark that a template is being extracted instead of a thing. * Adapt thing creation to rfc thing create command has been split in two commands: - thing create -> create a thing from a template. name parameter is optional and, if it's present, it overrides the name provided by the template - thing clone -> create a thing from an existing thing. name parameter of the new thing is mandatory thing templates have been aligned with general iot cloud templates concept now templates like this: https://github.com/bcmi-labs/cloud-templates/blob/main/templates/home-security-alarm/resources/thing.yml can be directly used to create new things. * Replace Properties with Variables * Update readme
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
adapt cloud-cli thing templates to the already established concept of template: - extracted templates are more "compliant" with the already known templates - standard cloud thing templates can now be used to create new things * Adapt template extraction remove properties_count, max_value, min_value, persist and tag fields add template name field change helper to remark that a template is being extracted instead of a thing. * Adapt thing creation to rfc thing create command has been split in two commands: - thing create -> create a thing from a template. name parameter is optional and, if it's present, it overrides the name provided by the template - thing clone -> create a thing from an existing thing. name parameter of the new thing is mandatory thing templates have been aligned with general iot cloud templates concept now templates like this: https://github.com/bcmi-labs/cloud-templates/blob/main/templates/home-security-alarm/resources/thing.yml can be directly used to create new things. * Replace Properties with Variables * Update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR tries to adapt cloud-cli thing templates to the already established concept of template
thing createcommand can now be used only to create new things from a template. The clone feature has been moved in a more specific commandthing clonepropertieshave been renamed intovariablesin the projectChange description
Additional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.