Skip to content

Remove ping command #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Remove ping command #18

merged 1 commit into from
Aug 5, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Aug 3, 2021

Motivation

mqtt diagnostic and debugging commands are moved into another specific tool.
This PR removes the ping command and all its dependencies (mqtt, codec etc..)

Change description

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested a review from zmoog August 3, 2021 16:29
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polldo polldo merged commit 2baf528 into main Aug 5, 2021
@polldo polldo deleted the polldo/ping-removal branch August 5, 2021 16:27
polldo added a commit that referenced this pull request Sep 2, 2022
mqtt diagnostic and debugging commands are moved into another specific tool.
This PR removes the ping command and all its dependencies (mqtt, codec etc..)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants