Skip to content

[WIRE-422] Custom templates support #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 29, 2024
Merged

[WIRE-422] Custom templates support #157

merged 21 commits into from
Jul 29, 2024

Conversation

rjtokenring
Copy link
Collaborator

Motivation

Support for custom template lifecycle

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@rjtokenring rjtokenring changed the title Custom templates support [WIRE-422] Custom templates support Jul 26, 2024
@rjtokenring rjtokenring marked this pull request as ready for review July 26, 2024 08:45
Copy link
Collaborator

@mirkokurt mirkokurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a great work! Thank you for adding this feature.
Since this is an entirely new use case for the Cloud-cli, what do you think about adding a new section in the readme explaining how to handle custom templates?

@@ -0,0 +1,70 @@
#include <ArduinoIoTCloud.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally put the sitewise template in the repo as example?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was my error... this is a test template used in manual test. Removed, thanks.

@rjtokenring
Copy link
Collaborator Author

Wow, this is a great work! Thank you for adding this feature. Since this is an entirely new use case for the Cloud-cli, what do you think about adding a new section in the readme explaining how to handle custom templates?

Yes, will add

@rjtokenring rjtokenring merged commit 5ca90df into main Jul 29, 2024
7 checks passed
@rjtokenring rjtokenring deleted the custom-templates branch July 29, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants