-
-
Notifications
You must be signed in to change notification settings - Fork 4
[WIRE-422] Custom templates support #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
621e341
to
96e4dbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is a great work! Thank you for adding this feature.
Since this is an entirely new use case for the Cloud-cli, what do you think about adding a new section in the readme explaining how to handle custom templates?
@@ -0,0 +1,70 @@ | |||
#include <ArduinoIoTCloud.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intentionally put the sitewise template in the repo as example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was my error... this is a test template used in manual test. Removed, thanks.
Yes, will add |
Motivation
Support for custom template lifecycle
Reviewer checklist
main
.CONTRIBUTING.md
) and are well formatted.