Skip to content

Add unit tests #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2021
Merged

Add unit tests #13

merged 2 commits into from
Jul 29, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Jul 27, 2021

No description provided.

@polldo polldo requested review from zmoog, eclipse1985 and glumia July 27, 2021 09:38
zmoog
zmoog approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now encode() and deviceFromPorts() have a nice little test suite.

@polldo polldo marked this pull request as ready for review July 29, 2021 09:23
@polldo polldo merged commit be4634d into main Jul 29, 2021
@polldo polldo deleted the polldo/tests branch July 29, 2021 09:24
polldo pushed a commit that referenced this pull request Sep 2, 2022
@polldo
Add unit tests (#13)
0eda7e3
polldo pushed a commit that referenced this pull request Sep 2, 2022
@polldo
Add unit tests (#13)
680927f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@glumia glumia glumia approved these changes

@eclipse1985 eclipse1985 Awaiting requested review from eclipse1985

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polldo @zmoog @glumia