Skip to content

Introduce organization optional parameter in credentials #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Aug 1, 2022

Motivation

We need to support RBAC in cloud-cli.
The concept of organizations should be introduced and propagated to calls to iot-api.

Change description

  • Add an optional parameter to the credentials.
  • Rename credentials IsEmpty in Complete to be consistent.
  • Adjust credentials tests.
  • Propagate all the credentials to iot NewClient and use the new organization param to set an header.
  • Prompt users to insert organization-id during credentials init command.

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested a review from eclipse1985 August 1, 2022 18:51
@polldo polldo force-pushed the polldo/organization branch from a276f3f to d6969de Compare August 2, 2022 17:28
@polldo polldo force-pushed the polldo/organization branch from b2f668d to b0a59b2 Compare August 2, 2022 17:39
@polldo polldo merged commit 9171cda into main Aug 2, 2022
@polldo polldo deleted the polldo/organization branch August 2, 2022 17:40
polldo added a commit that referenced this pull request Sep 2, 2022
Credentials can now also include an optional organization ID that specifies the organization to use.
polldo added a commit that referenced this pull request Sep 2, 2022
Credentials can now also include an optional organization ID that specifies the organization to use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants