Skip to content

Refactor cli package #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

Refactor cli package #103

merged 1 commit into from
Aug 2, 2022

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Apr 15, 2022

Motivation

refactor is never a bad thing

Change description

  • avoid global variables
  • run functions take flags as argument > this allows to call them in tests
  • put the error handling (with os.Exit()) in a single point

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested review from rsora and mirkokurt April 15, 2022 06:31
@polldo polldo force-pushed the polldo/pass-credentials branch from 0045fd6 to 5ab65bb Compare April 19, 2022 09:06
Base automatically changed from polldo/pass-credentials to main April 19, 2022 09:13
@polldo polldo force-pushed the polldo/refactor-cli branch from 8e2d95c to b12567a Compare August 2, 2022 17:22
@polldo polldo merged commit c0be3f5 into main Aug 2, 2022
@polldo polldo deleted the polldo/refactor-cli branch August 2, 2022 17:26
polldo added a commit that referenced this pull request Sep 2, 2022
@polldo
Refactor cli package (#103)
86b52b2 
- avoid global variables
- run functions take flags as argument > this allows to call them in tests
- put the error handling (with os.Exit()) in a single point
polldo added a commit that referenced this pull request Sep 2, 2022
@polldo
Refactor cli package (#103)
52bbe00 
- avoid global variables
- run functions take flags as argument > this allows to call them in tests
- put the error handling (with os.Exit()) in a single point
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora Awaiting requested review from rsora

@mirkokurt mirkokurt Awaiting requested review from mirkokurt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@polldo