Take credentials as command argument #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsora
approved these changes
Apr 14, 2022
mirkokurt
approved these changes
Apr 15, 2022
polldo
force-pushed
the
polldo/pass-credentials
branch
from
0045fd6 to
5ab65bb
Compare
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
allow to specify credentials when using the 'command' package as a go dependency - remove the config retrieval from the command package - the retrieval of the config is now done in the cli package - each command will take credentials as argument
polldo
added a commit
that referenced
this pull request
Sep 2, 2022
allow to specify credentials when using the 'command' package as a go dependency - remove the config retrieval from the command package - the retrieval of the config is now done in the cli package - each command will take credentials as argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to allow everyone to use the cloud-cli commands programmatically.
At the moment there is no way to specify credentials when using the command package as dependency (from an external project): they're automatically retrieved from a config file or from env.
Change description
this pr allows to specify credentials when executing commands belonging to the
commandpackageAdditional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.