added tests

Author: rjtokenring

internal/ota-api/dto.go

@@ -177,6 +177,9 @@ func hasReachedFlashState(states []State) bool {
 }
 
 func formatStateData(state, data string, firmware_size *int64, hasReceivedFlashState bool) string {
+	if data == "" || strings.ToLower(data) == "unknown" {
+		return ""
+	}
 	if state == "fetch" {
 		// This is the state 'fetch' of OTA progress. This contains a numer that represents the number of bytes fetched
 		if hasReceivedFlashState {

internal/ota-api/dto_test.go

@@ -0,0 +1,19 @@
+package otaapi
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestProgressBar_notCompletePct(t *testing.T) {
+	firmwareSize := int64(25665 * 2)
+	bar := formatStateData("fetch", "25665", &firmwareSize, false)
+	assert.Equal(t, "[=====     ] 50.00%", bar)
+}
+
+func TestProgressBar_ifFlashState_goTo100Pct(t *testing.T) {
+	firmwareSize := int64(25665 * 2)
+	bar := formatStateData("fetch", "25665", &firmwareSize, true) // If in flash status, go to 100%
+	assert.Equal(t, "[==========] 100.00%", bar)
+}