Skip to content

Commit 16b5fab

Browse files
committed
Changed var name
1 parent 0488894 commit 16b5fab

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

cli/ota/status.go

+11-10
Original file line numberDiff line numberDiff line change
@@ -38,28 +38,29 @@ type statusFlags struct {
3838

3939
func initOtaStatusCommand() *cobra.Command {
4040
flags := &statusFlags{}
41-
uploadCommand := &cobra.Command{
41+
statusCommand := &cobra.Command{
4242
Use: "status",
4343
Short: "OTA status",
4444
Long: "Get OTA status by OTA or device ID",
4545
Run: func(cmd *cobra.Command, args []string) {
46-
if err := runPrintOtaStatusCommand(flags); err != nil {
47-
feedback.Errorf("Error during ota get status: %v", err)
46+
if err := runPrintOtaStatusCommand(flags, cmd); err != nil {
47+
feedback.Errorf("\nError during ota get status: %v", err)
4848
os.Exit(errorcodes.ErrGeneric)
4949
}
5050
},
5151
}
52-
uploadCommand.Flags().StringVarP(&flags.otaID, "ota-id", "o", "", "OTA ID")
53-
uploadCommand.Flags().StringVarP(&flags.otaIDs, "ota-ids", "", "", "OTA IDs (comma separated)")
54-
uploadCommand.Flags().StringVarP(&flags.deviceId, "device-id", "d", "", "Device ID")
55-
uploadCommand.Flags().Int16VarP(&flags.limit, "limit", "l", 10, "Output limit (default: 10)")
56-
uploadCommand.Flags().StringVarP(&flags.sort, "sort", "s", "desc", "Sorting (default: desc)")
52+
statusCommand.Flags().StringVarP(&flags.otaID, "ota-id", "o", "", "OTA ID")
53+
statusCommand.Flags().StringVarP(&flags.otaIDs, "ota-ids", "", "", "OTA IDs (comma separated)")
54+
statusCommand.Flags().StringVarP(&flags.deviceId, "device-id", "d", "", "Device ID")
55+
statusCommand.Flags().Int16VarP(&flags.limit, "limit", "l", 10, "Output limit (default: 10)")
56+
statusCommand.Flags().StringVarP(&flags.sort, "sort", "s", "desc", "Sorting (default: desc)")
5757

58-
return uploadCommand
58+
return statusCommand
5959
}
6060

61-
func runPrintOtaStatusCommand(flags *statusFlags) error {
61+
func runPrintOtaStatusCommand(flags *statusFlags, command *cobra.Command) error {
6262
if flags.otaID == "" && flags.deviceId == "" && flags.otaIDs == "" {
63+
command.Help()
6364
return fmt.Errorf("required flag(s) \"ota-id\" or \"device-id\" or \"ota-ids\" not set")
6465
}
6566

0 commit comments

Comments
 (0)