Skip to content

Add test core extraction #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Add test core extraction #941

merged 1 commit into from
Sep 15, 2020

Conversation

rhaidiz
Copy link

@rhaidiz rhaidiz commented Sep 9, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Add further test for the extraction of zip cores.

See how to contribute

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2020

CLA assistant check
All committers have signed the CLA.

@cmaglie
Copy link
Member

cmaglie commented Sep 14, 2020

@rhaidiz would you like to check the errors in the linter: https://github.com/arduino/arduino-cli/pull/941/checks?check_run_id=1111482183#step:6:114

In general, we require that all CI tests pass before merging, (even if sometimes it may happen that the CI build fails for some external causes like downloads or services unavailable).

@rsora
Copy link
Contributor

rsora commented Sep 14, 2020

@rhaidiz you can use the command task check from the repo root folder to launch all the necessary linting checks as the CI does 👍

@rhaidiz
Copy link
Author

rhaidiz commented Sep 14, 2020

Sure thing 👍 , updated the commit and now the linter doesn't complain anymore.

@cmaglie cmaglie merged commit 1e5354b into arduino:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants