Skip to content

Fix uint64 un-aligned atomic access #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 16, 2018

Should fix #87.

/cc @wjwieland @OBerghmans

@cmaglie cmaglie added this to the next alpha preview milestone Nov 16, 2018
@cmaglie cmaglie self-assigned this Nov 16, 2018
@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #91 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   47.98%   47.93%   -0.05%     
==========================================
  Files          92       92              
  Lines        4087     4087              
==========================================
- Hits         1961     1959       -2     
- Misses       1889     1891       +2     
  Partials      237      237
Impacted Files Coverage Δ
common/formatter/output/libraries.go 81.08% <0%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32d52f...dacec19. Read the comment docs.

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-25-PR91-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-25-PR91-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-25-PR91-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-25-PR91-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-25-PR91-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@cmaglie cmaglie merged commit 7f6e96f into arduino:master Nov 16, 2018
@wjwieland
Copy link

I can confirm update-index for both core and lib on the linux 64 and linux ARM now work as expected. For some reason I get 404 - not found error when attempting to retrieve the Linux 32 tar.bz2 file from the above 'Build completed' download link, so have not yet tested on my 32 bit system.

Thanks again for the work on this!

@cmaglie cmaglie deleted the fix-arm64-atomic-access branch November 19, 2018 14:57
per1234 pushed a commit that referenced this pull request Nov 16, 2020
…daily work (always leading to additional 'code formatting' commits at the end of PRs (#91)
per1234 added a commit that referenced this pull request Aug 9, 2021
Add workflow to check for problems with certificates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update-index : panic: runtime error:
3 participants