Fix board list failing because stdin is already set #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Aug 25, 2020
Even if no board are attached to the host system, it's always another smoke-test that runs automatically. Having this check enabled, for example, would have prevented: arduino#904
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Aug 25, 2020
Even if no board are attached to the host system, it's always another smoke-test that runs automatically. Having this check enabled, for example, would have prevented: arduino#904
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Aug 25, 2020
This helper should avoid common pitfalls arising mainly after the adoption of the 'avrdude-stdin-hack'. For example see arduino#904 It also streamlines some of the most common operations (like process Kill or Signal).
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Aug 25, 2020
Even if no board are attached to the host system, it's always another smoke-test that runs automatically. Having this check enabled, for example, would have prevented: arduino#904
Merged
cmaglie
added a commit
that referenced
this pull request
Aug 25, 2020
* Added executils.Process helper This helper should avoid common pitfalls arising mainly after the adoption of the 'avrdude-stdin-hack'. For example see #904 It also streamlines some of the most common operations (like process Kill or Signal). * Removed no more used executils.Command * Run 'board list' test anyway Even if no board are attached to the host system, it's always another smoke-test that runs automatically. Having this check enabled, for example, would have prevented: #904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
Fixes
board listalways failing.board listfails.board listdoesn't fail.Nope.
No other info.
See how to contribute