Skip to content

Installer improvements #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 9, 2018
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 6, 2018

  • fixed precodintion check for already downloaded files
  • cleanup temps if installation is interrupted with CTRL+C during archive extraction

Should fix #43

@cmaglie cmaglie added the bug label Nov 6, 2018
@cmaglie cmaglie added this to the next alpha preview milestone Nov 6, 2018
@cmaglie cmaglie self-assigned this Nov 6, 2018
@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #89 into master will increase coverage by 0.51%.
The diff coverage is 74.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   47.46%   47.98%   +0.51%     
==========================================
  Files          92       92              
  Lines        4066     4087      +21     
==========================================
+ Hits         1930     1961      +31     
+ Misses       1903     1889      -14     
- Partials      233      237       +4
Impacted Files Coverage Δ
configs/preferences_txt_serializer.go 25.35% <0%> (ø) ⬆️
arduino/cores/cores.go 73.49% <100%> (+0.65%) ⬆️
commands/core/uninstall.go 68.51% <100%> (ø) ⬆️
configs/configuration.go 80.95% <100%> (+0.95%) ⬆️
commands/commands.go 49.23% <100%> (ø) ⬆️
configs/yaml_serializer.go 24.52% <33.33%> (+13.2%) ⬆️
arduino/resources/install.go 48% <66.66%> (+2.16%) ⬆️
commands/core/update_index.go 59.09% <69.23%> (-1.44%) ⬇️
commands/core/download.go 81.25% <72.72%> (+0.39%) ⬆️
commands/core/install.go 67.9% <78.26%> (+4.01%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dcd1ca...a32d52f. Read the comment docs.

as explained in arduino#81:

  It says all packages were downloaded:

    Updating index: package_index.json downloaded
    Updating index: package_esp8266com_index.json downloaded
    Updating index: package_lalala_index.json downloaded

  But when you run commands like arduino-cli core list or arduino-cli board listall it exits with an error:

    Error: loading json index file /Users/MY_USER_NAME/arduino-cli/data/package_lalala_index.json: invalid character '<' looking for beginning of value
    Failed to load http://google.com/package_lalala_index.json package index.
    Try updating all indexes with `arduino-cli core update-index`.

  It occurs, because package_lalala_index.json contains 404 HTML page.
@cmaglie cmaglie force-pushed the installer-improvements branch from 759c29a to 5a02ce4 Compare November 8, 2018 12:10
@arduino arduino deleted a comment from ArduinoBot Nov 8, 2018
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-24-PR89-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-24-PR89-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-24-PR89-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-24-PR89-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-24-PR89-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@arduino arduino deleted a comment from ArduinoBot Nov 8, 2018
@cmaglie cmaglie merged commit a32d52f into arduino:master Nov 9, 2018
@cmaglie cmaglie deleted the installer-improvements branch November 9, 2018 10:33
per1234 added a commit that referenced this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Сan't install tools if installation was interrupted
2 participants