Skip to content

Use v1 ref of arduino/setup-protoc action #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Use v1 ref of arduino/setup-protoc action #889

merged 1 commit into from
Aug 3, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 3, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Bug fix.

  • What is the current behavior?

CI workflows use the v1.0.0 ref of the arduino/setup-protoc action. This presents two issues:

  • Because that version of the action is missing metadata for its repo-token input, an Unexpected input(s) 'repo-token', valid inputs are ['version'] warning is displayed in every workflow run summary, which could result in confusion for contributors.
  • Pinning to a specific version results in either not benefiting from ongoing development, or the need to update the workflows on every release.
  • What is the new behavior?

The v1 ref of the action is specified, which has two benefits:

  • The "unexpected input" warning is no longer displayed in the workflow run summaries.
  • The workflow will automatically use any minor or patch releases of the action, but will require manual updating in the event that breaking changes result in a major version release.
  • Does this PR introduce a breaking change?

No.

The v1.1.0 version of the action neglected to define its repo-token input in the metadata, which results in a `Unexpected input(s) 'repo-token', valid inputs are ['version']` warning shown in the workflow summary on every run. The v1.1.1 release remedies this.

The use of the v1 ref will allow the workflows to benefit from any new releases of the action that don't cause breaking changes.
@per1234 per1234 merged commit 67b47b6 into arduino:master Aug 3, 2020
@per1234 per1234 deleted the update-setup-protoc-action branch August 3, 2020 19:46
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants