Skip to content

[skip changelog] Disable scheduled workflows that would always fail from running in forks #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2020
Merged

[skip changelog] Disable scheduled workflows that would always fail from running in forks #888

merged 2 commits into from
Aug 4, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 2, 2020

These workflows use resources that are only available when run in the arduino/arduino-cli repository, so would always fail when they run in a repository. They are of no value to fork repositories. They are triggered by the schedule event, so they cause regular annoying and confusing workflow failure notifications for every fork owner.

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Bug fix.

  • What is the current behavior?

It's extremely annoying to have a fork of this workflow with GitHub Actions workflows enabled because there are multiple workflows that are triggered by schedule events which rely on secrets that are only defined when run in the upstream repository. This causes the fork owner to get lots of notifications of failed workflow runs.

  • What is the new behavior?

Scheduled workflows of no value to contributors are configured to only run when in the arduino/arduino-cli repository.

  • Does this PR introduce a breaking change?

No.

@rsora rsora self-requested a review August 3, 2020 15:46
@rsora
Copy link
Contributor

rsora commented Aug 3, 2020

@per1234 Do we want to include the check also for the https://github.com/arduino/arduino-cli/blob/master/.github/workflows/link-validation.yaml workflow?

per1234 added 2 commits August 4, 2020 00:31
These workflows use resources that are only available when run in the arduino/arduino-cli repository, so would always fail when they run in a repository. They are of no value to fork repositories. They are triggered by the schedule event, so they cause regular annoying and confusing workflow failure notifications for every fork owner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants