Skip to content

Various improvements in compile / upload #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2018

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 26, 2018

  • The exported compiled binary now does not contains the FQBN "config" part anymore. This means that, for example, the default exported file for arduino:avr:mega:cpu=atmega1280 will be called Blink.arduino.avr.mega.hex instead of Blink.arduino.avr.mega.cpu=atmega1280.hex.

The change above should fix #64

  • The compile command now has a -o, --output to manually specifiy the output filename for the compiled binary.
  • The upload command now has a -i, --input to manually specify the input filename of the binary to upload to the board.

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-20-PR79-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-20-PR79-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-20-PR79-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-20-PR79-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-20-PR79-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #79 into master will increase coverage by 0.44%.
The diff coverage is 65.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   46.99%   47.44%   +0.44%     
==========================================
  Files          92       92              
  Lines        4039     4064      +25     
==========================================
+ Hits         1898     1928      +30     
+ Misses       1906     1903       -3     
+ Partials      235      233       -2
Impacted Files Coverage Δ
commands/upload/upload.go 12.06% <33.33%> (+3.15%) ⬆️
commands/compile/compile.go 59.76% <89.13%> (+7.13%) ⬆️
common/formatter/output/libraries.go 86.48% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e825c0...88213c6. Read the comment docs.

@cmaglie cmaglie added this to the next alpha milestone Oct 26, 2018
@brusherru
Copy link

It works! 🙌
Thanks a lot!

@cmaglie cmaglie merged commit 59436ca into arduino:master Oct 30, 2018
@cmaglie cmaglie deleted the compile-output branch October 30, 2018 15:16
per1234 added a commit that referenced this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't upload compiled code on esp8266
3 participants