Skip to content

fix typos #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arduino/builder/sketch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func TestCopyAdditionalFiles(t *testing.T) {
require.Len(t, s1.AdditionalFiles, 1)

// copy the sketch over, create a fake main file we don't care about it
// but we need it for `SketchLoad` to suceed later
// but we need it for `SketchLoad` to succeed later
err = builder.SketchCopyAdditionalFiles(s1, tmp)
require.Nil(t, err)
fakeIno := filepath.Join(tmp, fmt.Sprintf("%s.ino", filepath.Base(tmp)))
Expand Down
4 changes: 2 additions & 2 deletions cli/core/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,13 @@ func runInstallCommand(cmd *cobra.Command, args []string) {
}

for _, platformRef := range platformsRefs {
plattformInstallReq := &rpc.PlatformInstallReq{
platformInstallReq := &rpc.PlatformInstallReq{
Instance: inst,
PlatformPackage: platformRef.PackageName,
Architecture: platformRef.Architecture,
Version: platformRef.Version,
}
_, err := core.PlatformInstall(context.Background(), plattformInstallReq, output.ProgressBar(), output.TaskProgress())
_, err := core.PlatformInstall(context.Background(), platformInstallReq, output.ProgressBar(), output.TaskProgress())
if err != nil {
feedback.Errorf("Error during install: %v", err)
os.Exit(errorcodes.ErrGeneric)
Expand Down
2 changes: 1 addition & 1 deletion cli/core/search.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func runSearchCommand(cmd *cobra.Command, args []string) {

resp, err := core.PlatformSearch(inst.GetId(), arguments, allVersions)
if err != nil {
feedback.Errorf("Error saerching for platforms: %v", err)
feedback.Errorf("Error searching for platforms: %v", err)
os.Exit(errorcodes.ErrGeneric)
}

Expand Down
2 changes: 1 addition & 1 deletion cli/lib/search.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func runSearchCommand(cmd *cobra.Command, args []string) {
Query: (strings.Join(args, " ")),
})
if err != nil {
feedback.Errorf("Error saerching for Library: %v", err)
feedback.Errorf("Error searching for Library: %v", err)
os.Exit(errorcodes.ErrGeneric)
}

Expand Down
4 changes: 2 additions & 2 deletions legacy/builder/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -434,12 +434,12 @@ func QuoteCppPath(path *paths.Path) string {
// is a string contained in double quotes, with any backslashes or
// quotes escaped with a backslash. If a valid string was present at the
// start of the given line, returns the unquoted string contents, the
// remaineder of the line (everything after the closing "), and true.
// remainder of the line (everything after the closing "), and true.
// Otherwise, returns the empty string, the entire line and false.
func ParseCppString(line string) (string, string, bool) {
// For details about how these strings are output by gcc, see:
// https://github.com/gcc-mirror/gcc/blob/a588355ab948cf551bc9d2b89f18e5ae5140f52c/libcpp/macro.c#L491-L511
// Note that the documentaiton suggests all non-printable
// Note that the documentation suggests all non-printable
// characters are also escaped, but the implementation does not
// actually do this. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51259
if len(line) < 1 || line[0] != '"' {
Expand Down