update compile --build-path to support both relative and absolute flags #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinay-lanka thanks for submitting this PR! Can you please also add a couple of tests (including the one in the issue #630) in order to ease the review process? As a side note, can you please rebase your code on master? |
vinay-lanka
force-pushed
the
compile-build-flags
branch
from
91579ab to
708459e
Compare
update compile --build-path for both relative and absolute flags - Shifted fix from cli/compile/compile.go to command/compile/compile.go - Added tests for checking compile --build-path
vinay-lanka
force-pushed
the
compile-build-flags
branch
from
708459e to
31864fc
Compare
|
Hey, (Also sorry for the messy intermediate commit history, it's cleared now) |
|
Should I skip the windows CI test on this? I do not understand why the assertion error is like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change in compile.go to allow people to use either relative or absolute paths
A person would use relative paths assuming he wants it in the same directory as that of the sketch, allowing us to use the sketch path.
Can fix #630