Skip to content

Added dry-run mode in Compile command #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2020
Merged

Added dry-run mode in Compile command #619

merged 2 commits into from
Mar 13, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 13, 2020

It's useful in IDE integrations if we want to run the build but don't want to copy the build artifact in the sketch folder.

@cmaglie cmaglie self-assigned this Mar 13, 2020
@cmaglie cmaglie requested review from rsora and masci March 13, 2020 13:38
@cmaglie cmaglie added this to the 0.10.0 milestone Mar 13, 2020
rsora
rsora reviewed Mar 13, 2020
View reviewed changes
rsora
rsora suggested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, the rest is LGTM

@cmaglie
Update cli/compile/compile.go
e449ffb 
Co-Authored-By: Roberto Sora <[email protected]>
@cmaglie cmaglie merged commit fbd35df into arduino:master Mar 13, 2020
@cmaglie cmaglie deleted the dry-run branch March 13, 2020 14:14
@ianfixes
Copy link

Perform the build but do not copy the compile output file

This means that --dry-run does in fact do the compilation? What is the "compile output file"? Is it the compile logs or the compiled binary?

@ianfixes
Copy link

I think I can answer my own question -- it seems to prevent a directory called build from being copied into your Sketch directory.

@per1234
Copy link
Contributor

per1234 commented Nov 16, 2020

@ianfixes note this: #1051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

@masci masci Awaiting requested review from masci

Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cmaglie @ianfixes @per1234 @rsora