Skip to content

[skip changelog] Deploy docs website when merging on master #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

masci
Copy link
Contributor

@masci masci commented Mar 13, 2020

This PR changes the trigger to build the documentation website.

Before this PR, deployments were triggered on merged PRs but this doesn't work when a PR comes from a fork because of auth issues.
With this PR, docs deployment happens on a merge on master so the workflow will always run within this repo circumventing auth issues, not regarding if the PR comes from a fork or not.

Note: This PR contains a noop commit that will trigger a deploy.

@masci masci force-pushed the massi/docs-build branch from b02647f to eb80d2f Compare March 13, 2020 10:00
@masci masci marked this pull request as ready for review March 13, 2020 11:47
@masci masci changed the title Massi/docs build [skip changelog] Deploy docs website when merging on master Mar 13, 2020
@masci masci merged commit 6e62cda into master Mar 13, 2020
@masci masci deleted the massi/docs-build branch March 13, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants