Skip to content

Use grpc enumerations for LibraryLayout and LibraryLocation #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2020
Merged

Use grpc enumerations for LibraryLayout and LibraryLocation #613

merged 1 commit into from
Mar 11, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 10, 2020 •
edited
Loading

Alternative to #585

This one keeps the original enumerations instead of replacing them with the enumerations autogenerated from GRPC proto files.

@cmaglie cmaglie requested review from masci and rsora March 10, 2020 15:11
@cmaglie cmaglie self-assigned this Mar 10, 2020
rsora
rsora approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this PR to #585 as we avoid the rpc structs to be used directly in other places than commands
🥇

@cmaglie cmaglie merged commit cd2fa29 into arduino:master Mar 11, 2020
@cmaglie cmaglie deleted the grpc-lib-enums-2 branch March 11, 2020 14:51
@cmaglie cmaglie mentioned this pull request Mar 11, 2020
Closed
@cmaglie cmaglie added this to the 0.10.0 milestone Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

@masci masci Awaiting requested review from masci

Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @rsora