Remove upload port as required CLI parameter in "upload" command #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rsora merged 2 commits into master from rsora/upload-port

Mar 6, 2020

Contributor

rsora commented Mar 6, 2020 •

edited

Loading

This PR follows #454 and:

removes upload port as required CLI parameter in upload command to support board attach generated sketch.json file
adds a board attach integ test

rsora added 2 commits

March 6, 2020 11:24


          Remove upload port as required CLI parameter in "upload" command

f922d2b


          Add "board attach" integ test

9d165e6

masci approved these changes

View reviewed changes

rsora merged commit 8483cb2 into master

rsora deleted the rsora/upload-port branch

March 6, 2020 12:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet