Skip to content

Improve output message with config file creation #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

Improve output message with config file creation #595

merged 1 commit into from
Apr 2, 2020

Conversation

vinay-lanka
Copy link
Contributor

Improved output message with config file creation

Fix #586

@vinay-lanka
Copy link
Contributor Author

Could anyone take a look at this change?
I'd like to know if I could improve it in any way

ochui
ochui approved these changes Mar 26, 2020
View reviewed changes
Copy link

@ochui ochui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect solution! Thanks

rsora
rsora suggested changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!
I left a comment and a suggestion to do a bit of cleanup.

Thanks for your time!

rsora
rsora suggested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We are almost there 😺
Could you please rebase on latest master?

Then the PR will be ready for merging 👍

@vinay-lanka
Copy link
Contributor Author

Oh yeah, thanks for pointing it out. I rebased on the latest master.
Glad I was able to contribute! :)

@vinay-lanka vinay-lanka requested a review from rsora April 2, 2020 11:49
rsora
rsora approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@rsora rsora merged commit 322bc6a into arduino:master Apr 2, 2020
@rsora
Copy link
Contributor

rsora commented Apr 2, 2020

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochui ochui ochui approved these changes

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement] Improve the stdout of the config init --dest-dir command
3 participants
@vinay-lanka @rsora @ochui