Use default FQBN options when missing #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build completed. ⬇️ Linux 64: ⬇️ Linux 32: ⬇️ Linux ARM: ⬇️ Windows: ⬇️ OSX: ℹ️ To test this build:
|
per1234
added a commit
that referenced
this pull request
Aug 9, 2021
…heck Add check for potentially misspelled optional library.properties fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23.
This required a good amount of work because native maps in golang do not preserve insertion order (and this is correct since maps does not guarantee ordering). I had to update the
properties.Mapto achieve this, but this lead to a massive ripple effect becauseproperties.Mapcan no more aliasmap[string]stringand an API breaking change was needed.The actual fix is in the last commit b7307b8.