Terminate daemon command when parent process exits; added "--daemonize" flag to keep old behaviour #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we do this by default, without an option? I couldn't think of a use case where you would want a |
|
Maybe someone wants to keep it running as a real daemon... :-) BTW I can see that this is a rare use case, let me invert the default: I'm changing it from |
This is useful when the cli daemon is launched from an external process to avoid leaving zombie process if the parent process unexpectedly dies. If daemonization (so no stdin/stdout) is the intended behaviour the --daemonize flag must be used.
cmaglie
force-pushed
the
deamon-autoclose
branch
from
60b6203 to
bc9f1ad
Compare
masci
changed the title
masci
approved these changes
Nov 19, 2019
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Aug 20, 2023
Before arduino/arduino-cli#488, IDE2 required a way to stop the daemon process if the parent (backend) process crashed. However, this mechanism is no longer necessary as the CLI daemon process is not actually a true daemon process. Signed-off-by: Akos Kitta <[email protected]>
4 tasks
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Aug 20, 2023
Before arduino/arduino-cli#488, IDE2 required a way to stop the daemon process if the parent (backend) process crashed. However, this mechanism is no longer necessary as the CLI daemon process is not actually a true daemon process. Signed-off-by: Akos Kitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
arduino-clias a backend for the IDE, sometimes it happens that the IDE fails to terminate the process. This leaves a "zombie"arduino-cliprocess taking system resources and waiting for commands forever.This patch adds the
--autocloseflag to the cli daemon mode. When this option is flagged the cli monitors the 'os.Stdin` pipe and, if the parent process closes it, the cli terminates itself. Usually when the stdin is closed it means that the parent process is dead.