Skip to content

[skip changelog] Pin python version to 3.7 for integration tests #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Oct 29, 2019

As python 3.8 became available, the following error appeared in the test workflow:

pytest test
Traceback (most recent call last):
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\runpy.py", line 192, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\hostedtoolcache\windows\Python\3.8.0\x64\Scripts\pytest.exe\__main__.py", line 4, in <module>
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\site-packages\pytest.py", line 6, in <module>
    from _pytest.assertion import register_assert_rewrite
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\site-packages\_pytest\assertion\__init__.py", line 6, in <module>
    from _pytest.assertion import rewrite
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\site-packages\_pytest\assertion\rewrite.py", line 24, in <module>
    from _pytest.assertion import util
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\site-packages\_pytest\assertion\util.py", line 5, in <module>
    import _pytest._code
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\site-packages\_pytest\_code\__init__.py", line 2, in <module>
    from .code import Code  # noqa
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\site-packages\_pytest\_code\code.py", line 18, in <module>
    import pluggy
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\site-packages\pluggy\__init__.py", line 16, in <module>
    from .manager import PluginManager, PluginValidationError
  File "c:\hostedtoolcache\windows\python\3.8.0\x64\lib\site-packages\pluggy\manager.py", line 6, in <module>

Using a "bleeding edge" python installation in this project is not a strict requirement, so I simply pin the python version.

@rsora rsora changed the title [skip changelog] Pin python version to 3.7 [skip changelog] Pin python version to 3.7 for integration tests Oct 29, 2019
@rsora rsora merged commit 3ad5e1a into master Oct 29, 2019
@rsora rsora deleted the rsora/pin-python branch October 29, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants