Skip to content

[skip changelog] Force windows env to use bash as shell instead of powershell #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 28, 2019
Merged

[skip changelog] Force windows env to use bash as shell instead of powershell #453

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b1edc0d
[skip changelog] Force windows env to use cmd as shell instead of pow…
Oct 25, 2019
7dff102
temporarly enable only windows for test flow
Oct 25, 2019
cf13903
moved up cmd default shell for windows at job level
Oct 25, 2019
9db8457
revert and enable all
Oct 25, 2019
b7971d7
disable macos
Oct 25, 2019
fe0c1e8
force use of cmd on windows only for go getting dependencies
Oct 25, 2019
15c4b39
typo
Oct 25, 2019
7b1ece2
typo
Oct 25, 2019
86569aa
test using `bash` as default shell
Oct 28, 2019
34d923b
cleanup task and comment
Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,14 @@ jobs:
go-version: '1.13'

- name: Install Go deps
# Since 10/23/2019 pwsh is the default shell
# on Windows, but pwsh fails to install protoc-gen-go so
# we force bash as default shell for all OSes in this task
run: |
go get github.com/golangci/govet
go get golang.org/x/lint/golint
go get github.com/golang/protobuf/protoc-gen-go
shell: bash

- name: Install Taskfile
uses: Arduino/actions/setup-taskfile@master
Expand Down