Skip to content

Removed globals.HTTPClientHeader global #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

Removed globals.HTTPClientHeader global #438

merged 1 commit into from
Oct 7, 2019

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 7, 2019

Fix #414

/cc @rsora

@cmaglie
Removed globals.HTTPClientHeader global
4bfb29a 
To increase thread-safery and allow adding extra headers if needed.
@cmaglie cmaglie requested a review from rsora October 7, 2019 16:42
rsora
rsora approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch indeed!

@rsora rsora merged commit 63da3d8 into arduino:master Oct 7, 2019
@cmaglie cmaglie deleted the robustness-fix2 branch October 7, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map read and map write when working with the daemon
2 participants
@cmaglie @rsora