Skip to content

Replace default dummy version #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2019
+2 −4
Merged

Replace default dummy version #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e22f6e
replace default dummy version that overlaps with a real version with …
Sep 18, 2019
cd535e3
remove redundant VERSIONSTRING build var from taskfile
Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,10 @@ vars:
sh: echo `go list ./... | grep -v legacy | tr '\n' ' '`

# build vars
VERSIONSTRING: "0.3.7-alpha.preview"
COMMIT:
sh: echo ${TRAVIS_COMMIT:-`git log -n 1 --format=%h`}
LDFLAGS: >
-ldflags '-X github.com/arduino/arduino-cli/version.versionString={{.VERSIONSTRING}}
-X github.com/arduino/arduino-cli/version.commit={{.COMMIT}}'
-ldflags '-X github.com/arduino/arduino-cli/version.commit={{.COMMIT}}'

# test vars
GOFLAGS: "-timeout 10m -v -coverpkg=./... -covermode=atomic"
Expand Down
2 changes: 1 addition & 1 deletion version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
)

var (
defaultVersionString = "0.3.7-alpha.preview"
defaultVersionString = "0.0.0-git"
versionString = ""
commit = ""
)
Expand Down