Show core name when listing boards #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
added
component/CLI
topic: documentation
masci
changed the title
rsora
approved these changes
Sep 5, 2019
per1234
approved these changes
Sep 6, 2019
cmaglie
approved these changes
Sep 6, 2019
cli/board/list.go
Outdated
| @@ -100,15 +101,17 @@ func outputListResp(ports []*rpc.DetectedPort) { | |||
| for _, b := range boards { | |||
| board := b.GetName() | |||
| fqbn := b.GetFQBN() | |||
| t.AddRow(address, protocol, board, fqbn) | |||
| core := fqbn[:strings.LastIndex(fqbn, ":")] | |||
There was a problem hiding this comment.
we have some infra for FQBN parsing here https://github.com/arduino/arduino-cli/blob/master/arduino/cores/fqbn.go#L36 that would be nice using here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191
Now that #336 has been released, the vicious cycle of not knowing the board name if the corresponding core is not available, and not knowing which core to install without the board name, is finally broken.
To help users who are not familiar with the FQBN concept to better understand which core has to be installed, a new column in the output of
board listwas added to show the name of the core that supports the detected board.The README was updated accordingly.
Note: the core name wasn't added to the JSON output because that would require a non trivial amount of code - provided that the JSON output is supposed to be read by a machine and provided that the name of the core can be easily deduced from the data the CLI already provides, my advice is to avoid making the code too complex and let client applications do a little extra work when needed.