Skip to content

[skip changelog] Add coverage for legacy tests #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .codecov.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
comment: off

ignore:
- legacy/**/*
# ignore:
# - legacy/**/*

coverage:
status:
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,20 @@ jobs:
file: ./coverage_unit.txt
flags: unit

- name: Send legacy tests coverage to Codecov
# Since secrets aren't available on forks, we only
# upload coverage on `push`. This might change if
# Codecov whitelists GitHub, lifting the need
# for a token.
if: >
matrix.operating-system != 'windows-2019' &&
github.event_name == 'push'
uses: codecov/[email protected]
with:
token: ${{secrets.CODECOV_TOKEN}}
file: ./coverage_legacy.txt
flags: unit

- name: Send integration tests coverage to Codecov
# Since secrets aren't available on forks, we only
# upload coverage on `push`. This might change if
Expand Down
2 changes: 1 addition & 1 deletion Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ tasks:
test-legacy:
desc: Run tests for the `legacy` package
cmds:
- go test {{ default "-v -failfast" .GOFLAGS }} ./legacy/...
- go test {{ default "-v -failfast" .GOFLAGS }} -coverprofile=coverage_legacy.txt ./legacy/...

test-unit-race:
desc: Run unit tests only with race condition detection
Expand Down