Skip to content

[skip changelog] Revert the gRPC client example to a runnable go program #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2019
Merged

[skip changelog] Revert the gRPC client example to a runnable go program #361

merged 3 commits into from
Aug 28, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Aug 27, 2019

Fixes #353

@masci masci added the topic: documentation Related to documentation for the project label Aug 27, 2019
@masci masci requested a review from per1234 August 27, 2019 14:34
rsora
rsora approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmaglie
cmaglie requested changes Aug 28, 2019
View reviewed changes
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small doc fix, for the rest 👍

@masci masci merged commit e3c2953 into master Aug 28, 2019
@masci masci deleted the massi/example branch August 28, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie requested changes

@rsora rsora rsora approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees
No one assigned
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gRPC client example was converted to a test but that is not what it was intended for
3 participants
@masci @cmaglie @rsora