Skip to content

[skip changelog] deprecate latest links #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2019
Merged

[skip changelog] deprecate latest links #346

merged 3 commits into from
Aug 19, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Aug 14, 2019

No description provided.

@masci masci added the topic: documentation Related to documentation for the project label Aug 14, 2019
@masci masci requested a review from per1234 August 14, 2019 10:03
Copy link
Contributor

@gvarisco gvarisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-Authored-By: per1234 <[email protected]>
Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave the latest url as a 304 REDIRECT to the actual latest archive. I discussed with @mastrolinux and he agrees so we should avoid merging this PR IMO 🙂

@mastrolinux mastrolinux merged commit 4d36bac into master Aug 19, 2019
@mastrolinux
Copy link
Contributor

We will still make a 302 and then change the README accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants