Skip to content

[skip changelog] Remove protobuf workaround on AppVeyor #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2019
Merged

[skip changelog] Remove protobuf workaround on AppVeyor #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b15aa0
Upgrade protobuf to v3.9.1 for AppVeyor
zmoog Aug 7, 2019
37bcffd
Bump drone.io Docker image from 1.0 to 1.1 (#329)
Aug 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,26 @@ name: test

steps:
- name: lint
image: arduino/arduino-cli:drone-1.0
image: arduino/arduino-cli:drone-1.1.0
commands:
# Check if the Go code is properly formatted and run the linter
- task check
# Ensure protobufs compile without errors
- task protoc

- name: build
image: arduino/arduino-cli:drone-1.0
image: arduino/arduino-cli:drone-1.1.0
commands:
- task build

- name: test
image: arduino/arduino-cli:drone-1.0
image: arduino/arduino-cli:drone-1.1.0
commands:
- task test-unit
- task test-legacy

- name: integration
image: arduino/arduino-cli:drone-1.0
image: arduino/arduino-cli:drone-1.1.0
commands:
- pip install -r test/requirements.txt
- task test-integration
Expand All @@ -32,7 +32,7 @@ steps:
# Contrary to other CI platforms, uploading reports to Codecov requires Drone to provide a token.
# To avoid exposing the Codecov token to external PRs, we only upload coverage when we merge on
# `master`.
image: arduino/arduino-cli:drone-1.0
image: arduino/arduino-cli:drone-1.1.0
environment:
CODECOV_TOKEN:
from_secret: codecov_token
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ install:
# protobuf tooling needed at test time. We use a very old version of the compiler
# because of this: https://github.com/protocolbuffers/protobuf/issues/3957
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this notice now that we can get latest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get the latest also on the Docker image used for the unix builds on drone.io? Now it's using the v3.8.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah let's consolidate versions across different platforms 👍

- go get github.com/golang/protobuf/protoc-gen-go
- curl -o protoc.zip -LO https://github.com/protocolbuffers/protobuf/releases/download/v3.4.0/protoc-3.4.0-win32.zip
- curl -o protoc.zip -LO https://github.com/protocolbuffers/protobuf/releases/download/v3.9.1/protoc-3.9.1-win32.zip
- 7z x protoc.zip -o%PROTOC_PATH%

test_script:
Expand Down