Skip to content

ctags arm64 osx64 support #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2019
Merged

ctags arm64 osx64 support #304

merged 2 commits into from
Jul 24, 2019

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Jul 23, 2019

This PR updates the ctags metadata for the following platforms:

  • aarch64-linux (arm 64 bit)
  • x86_64-apple (macOS 64 bit)
    In order to force the arduino-cli to download the correct version of the Arduino ctags binary tool (https://github.com/arduino/ctags) for each platform

regarding the arm 64 bit platforms
The PR completes the arm64 support effort started in #204, solving the following error that happened when using the cli built and executed on an arm64 board (i.e. NVIDIA Jetson)

downloading builtin:[email protected] tool: tool not available for your OS

This PR also solves #292 together with Arduino CI pipeline configuration to enable the arm64 build.

regarding the macOS 64 bit platforms
This PR updates also the metadata for the macOS platform in order to download a ctag binary that complies with the 64bit transition for this OS, and stopping the "optimization" popup warning during the arduino-cli utilization on macOS High Sierra 10.13.4 and later.
image

Roberto Sora added 2 commits July 23, 2019 16:58
The cli automatically downloads this tool during its initial
configuration step The ctags tool provided by Arduino was missing for
download, causing the cli to breaks with a `downloading
builtin:[email protected] tool: tool not available for your OS` error.
This commit fixes the error defining pointers to Arduino downloads server
@rsora
Copy link
Contributor Author

rsora commented Jul 23, 2019

@ArduinoBot build this please

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-150-PR304-linux64.tar.bz2

⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-150-PR304-linux32.tar.bz2

⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-150-PR304-linuxarm.tar.bz2

⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-150-PR304-windows.zip

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-150-PR304-macosx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@rsora rsora marked this pull request as ready for review July 23, 2019 17:09
@gvarisco gvarisco self-requested a review July 24, 2019 09:27
Copy link
Contributor

@gvarisco gvarisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on macOS 10.14.6 (18G84)

@rsora rsora merged commit a7cf52c into master Jul 24, 2019
@rsora rsora deleted the rsora/ctags-arm64-osx64-support branch July 24, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants