Use BoardsManifest if Boards is not applicable

[kittaakos]

This patch falls back to the BoardsManifest when the Boards is not
available.

When the Boards are not installed, hence unavailable, the produced
gRPC instance won't contain the FQBN but the Name only.

This patch is a kind of a workaround for #277. The name of the boards will be still available, although the FQBN cannot be accessed.

Let me know what you think about this patch. Thanks!

Signed-off-by: Akos Kitta [email protected]

[CLAassistant]

All committers have signed the CLA.

[kittaakos]

I am not sure this will work at all, I would have expected, names are unique, but it's not the case. I can see the following board names on my client:

[kittaakos]

It's because both the arduino:[email protected] and arduino:[email protected] platform releases contain the same Arduino MKR Vidor 4000 board.

[csweichel]

This is certainly somewhat unexpected, but I'd think it depends on the use-case where this board list is used. In case of the board manager for example, after de-duping the list it would certainly be useful.

@masci what do you think?

[masci]

Code is clear and well commented so I'm not concerned for having this workaround in the codebase. I think we should merge this while elaborating a fix for the root cause of #277.

[masci]

@32leaves agree, that problem must be solved upstream, if deduping works for you in the meantime and it's helpful for the user (which I believe it's the case) we should go for it.

[kittaakos]

Code is clear and well commented

There is a typo, let me fix that now.

[kittaakos]

let me fix that now.

Done.

[masci]

@ArduinoBot build this please

[rsora]

@ArduinoBot build this please

[ArduinoBot]

✅ Build completed.

⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-linux64.tar.bz2

⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-linux32.tar.bz2

⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-linuxarm.tar.bz2

⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-windows.zip

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-osx.zip

ℹ️ To test this build:

1. Just replace arduino-cli binary with the provided one

[kittaakos]

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-osx.zip

Dear @ArduinoBot, the download link for macOS incorrect 😉

     _                     _                 _                       _       _                         
    | |                   | |               | |                     | |     (_)                        
  __| | _____      ___ __ | | ___   __ _  __| |___      __ _ _ __ __| |_   _ _ _ __   ___      ___ ___ 
 / _` |/ _ \ \ /\ / | '_ \| |/ _ \ / _` |/ _` / __|    / _` | '__/ _` | | | | | '_ \ / _ \    / __/ __|
| (_| | (_) \ V  V /| | | | | (_) | (_| | (_| \__ \_  | (_| | | | (_| | |_| | | | | | (_) |  | (_| (__ 
 \__,_|\___/ \_/\_/ |_| |_|_|\___/ \__,_|\__,_|___(_)  \__,_|_|  \__,_|\__,_|_|_| |_|\___/  (_\___\___|

Should end with -macosx.zip.

[rsora]

@ArduinoBot build this please

[ArduinoBot]

✅ Build completed.

⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-linux64.tar.bz2

⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-linux32.tar.bz2

⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-linuxarm.tar.bz2

⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-windows.zip

⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-macosx.zip

ℹ️ To test this build:

1. Just replace arduino-cli binary with the provided one

[rsora]

@kittaakos good catch!
Now the link is fixed.

[masci]

@kittaakos can you rebase on master (again, sorry), the CI should pass then 🙇‍♂️

[kittaakos]

The builds are green now.