Skip to content

Fixed integration test #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Apr 22, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

  1. Fix ArduinoIoTCloud version to 2.4.1 (the latest versions have fewer files and do not trigger the objs.a creation)
  2. Merge two parallel tests because they actually need to be performed sequentially since we are checking that the compiled artifacts on the former are reused on the latter.

What is the current behavior?

CI is failing

What is the new behavior?

CI is green

Does this PR introduce a breaking change, and is titled accordingly?

Other information

1. Fix ArduinoIoTCloud version to 2.4.1 (the latest versions have fewer
   files and do not trigger the objs.a creation)
2. Merge two parallel tests because they actually need to be performed
   sequentially since we are checking that the compiled artifacts on
   the former are reused on the latter.
@cmaglie cmaglie self-assigned this Apr 22, 2025
@cmaglie cmaglie added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Apr 22, 2025
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.83%. Comparing base (23ed1b1) to head (73056e9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2895   +/-   ##
=======================================
  Coverage   67.83%   67.83%           
=======================================
  Files         238      238           
  Lines       22418    22419    +1     
=======================================
+ Hits        15208    15209    +1     
  Misses       6010     6010           
  Partials     1200     1200           
Flag Coverage Δ
unit 67.83% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmaglie cmaglie requested a review from a team April 22, 2025 11:29
@cmaglie cmaglie merged commit aa62661 into arduino:master Apr 22, 2025
98 checks passed
@cmaglie cmaglie deleted the fix_integration_test branch April 22, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants