Some improvements to install.sh
#2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will show more information when the download fails.
-S, --show-error
When used with -s, --silent, it makes curl show an error message if it fails.
cmaglie
added
type: enhancement
3 tasks
cmaglie
changed the title
install.shinstall.sh
alessio-perugini
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
curlthe error reason is now displayed (this is the effect of the added--show-errorflag to be used in conjunction with--silent)What is the current behavior?
If
curlfails to download, a generic error is displayed.What is the new behavior?
If
curlfails to download, the specific error that cause the download failure is displayed.Does this PR introduce a breaking change, and is titled accordingly?
No.
Other information
Should help with #2667